Menu
▾
▴
#711 Overwriting LANGFILE_abc_NAME not possible anymore
I overwrite the language selection by defining something like this:
!define LANGFILE_French_NAME "French"
!define LANGFILE_Japanese_NAME "Japanese"
!define LANGFILE_SimpChinese_NAME "Simplified Chinese"
[...]
This is rather important, because the current solution to keep the language string free from 'foreign' characters is only a valid solution for the western world. iE "Français" can be displayed correctly in the USA and nearly in all Europe, but it' cant be displayed in Japan.
Defining LANGFILE_abc_NAME was even proposed by kichik himself (http://forums.winamp.com/showthread.php?threadid=281426). Even though this is stated as a hack, it was the only valid way to achieve the result.
Due to the code in LangFile.nsh, this isn't possible anymore. If you would change the macro LANGFILE to following, it would work again:
!macro LANGFILE IDNAME NAME
!ifdef LANGFILE_SETNAMES
!ifdef LANGFILE_IDNAME
!undef LANGFILE_IDNAME
!endif
!define LANGFILE_IDNAME "${IDNAME}"
!ifndef "LANGFILE_${IDNAME}_NAME"
!define "LANGFILE_${IDNAME}_NAME" "${NAME}"
!endif
!endif
!macroend
Logged In: YES
user_id=584402
Originator: NO
Thanks, fixed.