Received: (qmail 20484 invoked by uid 2012); 20 Jan 1999 16:47:39 -0000
Message-Id: <19990120164739.20483.qmail@hyperreal.org>
Date: 20 Jan 1999 16:47:39 -0000
From: David White <david@persimmon.com>
Reply-To: david@persimmon.com
To: apbugs@hyperreal.org
Subject: Does escape_uri need to be added to ap_compat.h
X-Send-Pr-Version: 3.2

>Number:         3725
>Category:       general
>Synopsis:       Does escape_uri need to be added to ap_compat.h
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Wed Jan 20 08:50:00 PST 1999
>Last-Modified:  Thu Jan 28 01:25:42 PST 1999
>Originator:     david@persimmon.com
>Organization:
>Release:        1.3.4
>Environment:
Digital Unix 4.0 (rev 878), gcc 2.8.1
>Description:
> Changes with Apache 1.3.4
> *) Renamed the macro escape_uri() to ap_escape_uri() which was
>    forgotten (because it was a macro) in the symbol renaming process.
>    [Ralf S. Engelschall]

Should escape_uri therefore be added to /src/include/ap_compat.h ?  Without it,
I'm unable to compile mod_auth_msql into Apache 1.3.4
>How-To-Repeat:

>Fix:
This does it for me:

--- ap_compat.h.orig    Wed Jan 20 11:34:47 1999
+++ ap_compat.h Wed Jan 20 11:25:11 1999
@@ -118,6 +118,7 @@
 #define escape_html                    ap_escape_html
 #define escape_path_segment            ap_escape_path_segment
 #define escape_shell_cmd               ap_escape_shell_cmd
+#define escape_uri                     ap_escape_uri
 #define excess_requests_per_child      ap_excess_requests_per_child
 #define exists_scoreboard_image        ap_exists_scoreboard_image
 #define finalize_request_protocol      ap_finalize_request_protocol
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: rse
State-Changed-When: Thu Jan 28 01:25:41 PST 1999
State-Changed-Why:
Comitted for Apache 1.3.5.
Thanks for the patch.
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request ]
[from a developer.                                      ]
[Reply only with text; DO NOT SEND ATTACHMENTS!         ]